Fix PAG int shorthand crash in LayerSkipConfig.indices#15
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
When perturbed_guidance_layers is a single int, wrap it in a list before building LayerSkipConfig so hook installation does not crash with TypeError. Co-authored-by: Simon Lynch <srlynch1@users.noreply.github.com>
This was referenced Jun 26, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
PerturbedAttentionGuidance(perturbed_guidance_layers=7, ...)crashes during hook installation withTypeErrorwhen PAG is active. The documented int shorthand for layer selection is broken.Root cause
The shorthand path passed a bare
inttoLayerSkipConfig.indices(typed aslist[int])._apply_layer_skip_hookcallslen(config.indices), which fails on an int. SLG/AutoGuidance had the same bug (PR #10); PAG was missed because it builds a single config with all layer indices instead of one config per layer.Fix
Wrap
perturbed_guidance_layersint shorthand to[int]before constructingLayerSkipConfig, matching SLG/AutoGuidance behavior.Validation
tests/guiders/test_perturbed_attention_guidance.pypytest tests/guiders/test_perturbed_attention_guidance.py— 2 passed